Add Cbf prefix to public type names of Kyoto#716
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Mar 28, 2025
Merged
Add Cbf prefix to public type names of Kyoto#716thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Cbf prefix to public type names of Kyoto#716thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
rustaceanrob
changed the title
Cbf prefix to public type namesCbf prefix to public type names of Kyoto
rustaceanrob
force-pushed
the
kyoto-naming-3-28
branch
2 times, most recently
from
06b60dd to
063ce6c
Compare
rustaceanrob
force-pushed
the
kyoto-naming-3-28
branch
from
063ce6c to
d5cafb9
Compare
thunderbiscuit
approved these changes
Mar 28, 2025
Member
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Looks great! The CbfComponents naming also makes intuitive sense to me. Awesome stuff for the upcoming release!
ACK d5cafb9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #700
Discussed in #700, technically every client offered currently in the FFI is a "light client". Compact block filters are the underpinning of the system, so all of the types can indicate that in their names. This removes all notion of
LightClientand replaces it with aCbfprefix (CBFlooked ugly imo)Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: